Support an unlimited rate limit everywhere #5667
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everywhere that `ratelimiter.New` is used, we now support `ratelimiter.NewUnlimited` when the value given is zero. In places that used to check to see that _both_ the numerator and the denominator were 0, they now only check to see if the numerator is zero. From a user perspective, the difference between 0 seconds, 0 milliseconds, and 0 hours is meaningless. It is clear that when they say zero, they mean zero.
|
Thanks so much for your contribution @doug-threatmate ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Everywhere that
ratelimiter.Newis used, we now supportratelimiter.NewUnlimitedwhen the value given is zero.In places that used to check to see that both the numerator and the denominator were 0, they now only check to see if the numerator is zero.
From a user perspective, the difference between 0 seconds, 0 milliseconds, and 0 hours is meaningless. It is clear that when they say zero, they mean zero.
Checklist