Patch OLM RBAC to allow deploying Hubble certgen cronjob #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cilium Helm chart for cilium <= 1.15 uses a ClusterRole and ClusterRoleBinding for the Hubble certgen CronJob. This is changed to a Role and RoleBinding for the Cilium 1.16 Helm chart. The OLM operator doesn't have permissions to create the ClusterRole and ClusterRoleBinding out of the box, so we patch the OLM operator ClusterRole to contain the rules that need to be created for the certgen CronJob.
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
bastjan
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cilium Helm chart for cilium <= 1.15 uses a ClusterRole and ClusterRoleBinding for the Hubble certgen CronJob. This is changed to a Role and RoleBinding for the Cilium 1.16 Helm chart.
The OLM operator doesn't have permissions to create the ClusterRole and ClusterRoleBinding out of the box, so we patch the OLM operator ClusterRole to contain the rules that need to be created for the certgen CronJob.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.