Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fqm-e bump to 1.3.1 and update Docker setup #140

Merged
merged 10 commits into from
Sep 13, 2023
Merged

Conversation

hossenlopp
Copy link
Contributor

@hossenlopp hossenlopp commented Sep 12, 2023

Summary

New behavior

  • npm run check no longer results in those two lint errors from ecqm-content-r4-2021/input/images/cql.js. I added a .eslintignore file for the ecqm-content-r4-2021 directory. I hope this is okay, let me know if it's not. I was tired of seeing those and now the prettier check seems to actually happen.
  • Otherwise, there should be no new behaviors.
  • upload-bundles npm script now is able to handle a directory of nested MADiE Measures and TestCase export bundles.
    Note: these will not execute in the server at the moment due to issues with relatedArtifact references in the Measure and Library resources and patient data queries

Code changes

  • .eslintignore - added this file to avoid those errors that we (I think) don't care about
  • package.json / package-lock.json - further upgraded the fqm-execution version
  • execQueue.js - Updated to use newer MeasureReportBuilder API.

Code changes Lauren made in previous fqm-e version bump PR

  • ci.yml, measure.service.js, base.service.test.js

Testing guidance

  • npm run check Reminder that sometimes a couple of these tests will fail. That is okay for now and something we need to address in separate tasking.
  • npm start make sure that all functionality works the same.

NOTE:

  • We had an in review PR for updating the fqm-execution version that I closed and just branched off of to upgrade the version even further. The previous PR is here for reference.

@github-actions
Copy link

github-actions bot commented Sep 12, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 93.67% 1287/1374
🟢 Branches 86.28% 371/430
🟢 Functions 93.75% 210/224
🟢 Lines 93.58% 1254/1340

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟢 src/queue/execQueue.js 93.88% (-3.85% 🔻) 100% 90% (+1.11% 🔼) 93.48% (-4.14% 🔻)

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 5472b80

src/util/bundleUtils.js Outdated Show resolved Hide resolved
src/util/bundleUtils.js Outdated Show resolved Hide resolved
src/util/bundleUtils.js Outdated Show resolved Hide resolved
@elsaperelli elsaperelli self-requested a review September 12, 2023 20:14
@elsaperelli elsaperelli self-assigned this Sep 12, 2023
@hossenlopp hossenlopp changed the title Fqm e bump dockerfix fqm-e bump to 1.3.1 and update Docker setup Sep 12, 2023
@hossenlopp
Copy link
Contributor Author

This is ready for review again. It should be noted that the (16.x, 5.0) checks will no longer run and they will show as issues in the checks on this PR and can be ignored.

Copy link
Contributor

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 very small comments but otherwise looks great!

src/scripts/uploadPremadeBundles.js Outdated Show resolved Hide resolved
Copy link
Contributor

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@hossenlopp
Copy link
Contributor Author

Closing because of removed checks blocking merge. New PR will be created.

@hossenlopp hossenlopp closed this Sep 13, 2023
@hossenlopp hossenlopp reopened this Sep 13, 2023
@hossenlopp hossenlopp merged commit c139906 into main Sep 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants