-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fqm-e bump to 1.3.1 and update Docker setup #140
Conversation
…E exports more gracefully
…s with docker run
Coverage reportTotal coverage
Show files with reduced coverage 🔻Reduced coverage
Report generated by 🧪jest coverage report action from 5472b80 |
…to upload-bundles script and switched to use uuidv4 for random id
…te in the entries as it should be required
This is ready for review again. It should be noted that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 very small comments but otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Closing because of removed checks blocking merge. New PR will be created. |
Summary
1.3.1
). See here for the release notes.New behavior
npm run check
no longer results in those two lint errors fromecqm-content-r4-2021/input/images/cql.js
. I added a.eslintignore
file for theecqm-content-r4-2021
directory. I hope this is okay, let me know if it's not. I was tired of seeing those and now the prettier check seems to actually happen.upload-bundles
npm script now is able to handle a directory of nested MADiE Measures and TestCase export bundles.Note: these will not execute in the server at the moment due to issues with relatedArtifact references in the Measure and Library resources and patient data queries
Code changes
.eslintignore
- added this file to avoid those errors that we (I think) don't care aboutpackage.json
/package-lock.json
- further upgraded the fqm-execution versionexecQueue.js
- Updated to use newer MeasureReportBuilder API.Code changes Lauren made in previous fqm-e version bump PR
ci.yml
,measure.service.js
,base.service.test.js
Testing guidance
npm run check
Reminder that sometimes a couple of these tests will fail. That is okay for now and something we need to address in separate tasking.npm start
make sure that all functionality works the same.NOTE: