Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(snmp_exporter): fix dry-runs on new machines #515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(snmp_exporter): fix dry-runs on new machines #515

wants to merge 1 commit into from

Conversation

pieterlexis-tomtom
Copy link

This does not fail a dry run on machines where snmp_exporter is not yet installed.

@github-actions github-actions bot added enhancement New feature or request roles/snmp_exporter and removed enhancement New feature or request labels Jan 15, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 18, 2025
@pieterlexis-tomtom
Copy link
Author

Is this really needed? ansible.builtin.systemd has full support for check_mode

From what I have noticed: if you run this role in check mode on a blank slate, the unitfile is not put unto the system. When the service is started (or restarted) the dry-run will error out with Could not find the requested service snmp_exporter: host, stopping the dry-run. I can try to do some more experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request roles/snmp_exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterlexis-tomtom @gardar