Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pve_exporter #519

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: add pve_exporter #519

wants to merge 9 commits into from

Conversation

juju4
Copy link
Contributor

@juju4 juju4 commented Jan 19, 2025

This is adapted from node_exporter with review as not golang but python.
Tested on Ubuntu 24.04

@github-actions github-actions bot added the enhancement New feature or request label Jan 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 19, 2025 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

The docs for this PR have been published here:
https://prometheus-community.github.io/ansible/pr/519

You can compare to the docs for the main branch here:
https://prometheus-community.github.io/ansible/branch/main

The docsite for this PR is also available for download as an artifact from this run:
https://github.com/prometheus-community/ansible/actions/runs/13358242260

File changes:

Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/ansible/ansible/docsbuild/base/_common_role.html b/home/runner/work/ansible/ansible/docsbuild/head/_common_role.html
index d80271e..34bc168 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/_common_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/_common_role.html
@@ -123,6 +123,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/alertmanager_role.html b/home/runner/work/ansible/ansible/docsbuild/head/alertmanager_role.html
index 71b6fb7..40ca07a 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/alertmanager_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/alertmanager_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/bind_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/bind_exporter_role.html
index ca42463..bed9d52 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/bind_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/bind_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/blackbox_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/blackbox_exporter_role.html
index 0e4cdf2..af97381 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/blackbox_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/blackbox_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/cadvisor_role.html b/home/runner/work/ansible/ansible/docsbuild/head/cadvisor_role.html
index aa55b45..ccfd203 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/cadvisor_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/cadvisor_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/chrony_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/chrony_exporter_role.html
index 8583d24..c26593b 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/chrony_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/chrony_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/consul_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/consul_exporter_role.html
index fc29b7b..f5e3262 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/consul_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/consul_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/environment_variables.html b/home/runner/work/ansible/ansible/docsbuild/head/environment_variables.html
index 65fb5a3..0c20182 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/environment_variables.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/environment_variables.html
@@ -92,6 +92,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/fail2ban_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/fail2ban_exporter_role.html
index cff6d4b..8a05947 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/fail2ban_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/fail2ban_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/index.html b/home/runner/work/ansible/ansible/docsbuild/head/index.html
index ef79ca7..b2ddb97 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/index.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/index.html
@@ -93,6 +93,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
@@ -186,6 +187,7 @@
 <li><p><a class="reference internal" href="process_exporter_role.html#ansible-collections-prometheus-prometheus-process-exporter-role"><span class="std std-ref">process_exporter role</span></a> – Prometheus Process exporter</p></li>
 <li><p><a class="reference internal" href="prometheus_role.html#ansible-collections-prometheus-prometheus-prometheus-role"><span class="std std-ref">prometheus role</span></a> – Installs and configures prometheus</p></li>
 <li><p><a class="reference internal" href="pushgateway_role.html#ansible-collections-prometheus-prometheus-pushgateway-role"><span class="std std-ref">pushgateway role</span></a> – Prometheus Pushgateway</p></li>
+<li><p><a class="reference internal" href="pve_exporter_role.html#ansible-collections-prometheus-prometheus-pve-exporter-role"><span class="std std-ref">pve_exporter role</span></a> – Prometheus Proxmox VE Exporter</p></li>
 <li><p><a class="reference internal" href="redis_exporter_role.html#ansible-collections-prometheus-prometheus-redis-exporter-role"><span class="std std-ref">redis_exporter role</span></a> – Prometheus redis_exporter</p></li>
 <li><p><a class="reference internal" href="smartctl_exporter_role.html#ansible-collections-prometheus-prometheus-smartctl-exporter-role"><span class="std std-ref">smartctl_exporter role</span></a> – Prometheus Smartctl Exporter</p></li>
 <li><p><a class="reference internal" href="smokeping_prober_role.html#ansible-collections-prometheus-prometheus-smokeping-prober-role"><span class="std std-ref">smokeping_prober role</span></a> – Prometheus Smokeping Prober</p></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/influxdb_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/influxdb_exporter_role.html
index b12f432..b2de993 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/influxdb_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/influxdb_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/ipmi_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/ipmi_exporter_role.html
index c28f554..5fc905f 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/ipmi_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/ipmi_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/memcached_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/memcached_exporter_role.html
index 0604f0f..aad7303 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/memcached_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/memcached_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/mongodb_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/mongodb_exporter_role.html
index f47a771..1847568 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/mongodb_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/mongodb_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/mysqld_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/mysqld_exporter_role.html
index 03d8072..faffa9a 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/mysqld_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/mysqld_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/nginx_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/nginx_exporter_role.html
index 84ec72d..62c576e 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/nginx_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/nginx_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/node_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/node_exporter_role.html
index 343150c..15411fd 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/node_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/node_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/nvidia_gpu_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/nvidia_gpu_exporter_role.html
index b12cad9..c18e052 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/nvidia_gpu_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/nvidia_gpu_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/postgres_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/postgres_exporter_role.html
index c16619a..7e88b32 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/postgres_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/postgres_exporter_role.html
@@ -105,6 +105,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/process_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/process_exporter_role.html
index cbdd298..90629c2 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/process_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/process_exporter_role.html
@@ -105,6 +105,7 @@
 </li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/prometheus_role.html b/home/runner/work/ansible/ansible/docsbuild/head/prometheus_role.html
index 08aa45b..e27487f 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/prometheus_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/prometheus_role.html
@@ -105,6 +105,7 @@
 </ul>
 </li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/pushgateway_role.html b/home/runner/work/ansible/ansible/docsbuild/head/pushgateway_role.html
index 9f861e2..1f23c48 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/pushgateway_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/pushgateway_role.html
@@ -22,7 +22,7 @@
       <script src="_static/sphinx_highlight.js?v=dc90522c"></script>
     <script src="_static/js/theme.js"></script>
     <link rel="search" title="Search" href="search.html" />
-    <link rel="next" title="prometheus.prometheus.redis_exporter role – Prometheus redis_exporter" href="redis_exporter_role.html" />
+    <link rel="next" title="prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter" href="pve_exporter_role.html" />
     <link rel="prev" title="prometheus.prometheus.prometheus role – Installs and configures prometheus" href="prometheus_role.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
 
 
@@ -105,6 +105,7 @@
 </li>
 </ul>
 </li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
@@ -325,7 +326,7 @@ To check whether it is installed, run <code class="code docutils literal notrans
 
 <footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
         <a href="prometheus_role.html" class="btn btn-neutral float-left" title="prometheus.prometheus.prometheus role – Installs and configures prometheus" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
-        <a href="redis_exporter_role.html" class="btn btn-neutral float-right" title="prometheus.prometheus.redis_exporter role – Prometheus redis_exporter" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
+        <a href="pve_exporter_role.html" class="btn btn-neutral float-right" title="prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
     </div>
 
   <hr/>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/redis_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/redis_exporter_role.html
index 66d70c2..3ed2260 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/redis_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/redis_exporter_role.html
@@ -23,7 +23,7 @@
     <script src="_static/js/theme.js"></script>
     <link rel="search" title="Search" href="search.html" />
     <link rel="next" title="prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter" href="smartctl_exporter_role.html" />
-    <link rel="prev" title="prometheus.prometheus.pushgateway role – Prometheus Pushgateway" href="pushgateway_role.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
+    <link rel="prev" title="prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter" href="pve_exporter_role.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
 
 
 
@@ -94,6 +94,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1 current"><a class="current reference internal" href="#">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a><ul>
 <li class="toctree-l2"><a class="reference internal" href="#entry-point-main-prometheus-redis-exporter">Entry point <code class="docutils literal notranslate"><span class="pre">main</span></code> – Prometheus redis_exporter</a><ul>
 <li class="toctree-l3"><a class="reference internal" href="#synopsis">Synopsis</a></li>
@@ -622,7 +623,7 @@ To check whether it is installed, run <code class="code docutils literal notrans
           
 
 <footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
-        <a href="pushgateway_role.html" class="btn btn-neutral float-left" title="prometheus.prometheus.pushgateway role – Prometheus Pushgateway" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
+        <a href="pve_exporter_role.html" class="btn btn-neutral float-left" title="prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
         <a href="smartctl_exporter_role.html" class="btn btn-neutral float-right" title="prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
     </div>
 
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/search.html b/home/runner/work/ansible/ansible/docsbuild/head/search.html
index 0e645c7..62d754c 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/search.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/search.html
@@ -93,6 +93,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/smartctl_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/smartctl_exporter_role.html
index bace073..10cdb60 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/smartctl_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/smartctl_exporter_role.html
@@ -94,6 +94,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1 current"><a class="current reference internal" href="#">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a><ul>
 <li class="toctree-l2"><a class="reference internal" href="#entry-point-main-prometheus-smartctl-exporter">Entry point <code class="docutils literal notranslate"><span class="pre">main</span></code> – Prometheus Smartctl Exporter</a><ul>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/smokeping_prober_role.html b/home/runner/work/ansible/ansible/docsbuild/head/smokeping_prober_role.html
index 16dd7d8..717b282 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/smokeping_prober_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/smokeping_prober_role.html
@@ -94,6 +94,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1 current"><a class="current reference internal" href="#">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a><ul>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/snmp_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/snmp_exporter_role.html
index d9c02fa..ed6220a 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/snmp_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/snmp_exporter_role.html
@@ -94,6 +94,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/systemd_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/systemd_exporter_role.html
index f5835f3..643c6c0 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/systemd_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/systemd_exporter_role.html
@@ -93,6 +93,7 @@
 <li class="toctree-l1"><a class="reference internal" href="process_exporter_role.html">prometheus.prometheus.process_exporter role – Prometheus Process exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="prometheus_role.html">prometheus.prometheus.prometheus role – Installs and configures prometheus</a></li>
 <li class="toctree-l1"><a class="reference internal" href="pushgateway_role.html">prometheus.prometheus.pushgateway role – Prometheus Pushgateway</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pve_exporter_role.html">prometheus.prometheus.pve_exporter role – Prometheus Proxmox VE Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="redis_exporter_role.html">prometheus.prometheus.redis_exporter role – Prometheus redis_exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smartctl_exporter_role.html">prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter</a></li>
 <li class="toctree-l1"><a class="reference internal" href="smokeping_prober_role.html">prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober</a></li>

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 19, 2025
gardar
gardar requested changes Jan 19, 2025
View reviewed changes
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the molecule ansible-test integration script, see tests/integration/targets

@github-actions github-actions bot added enhancement New feature or request roles/pve_exporter and removed enhancement New feature or request labels Jan 19, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 25, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 25, 2025
@juju4
Copy link
Contributor Author

juju4 commented Jan 25, 2025

Most molecule fails seem because no python3-virtualenv on almalinux-9 but this depends on epel/cbr repository. should this be included in role, call external role, or something else? preference?

@juju4
Copy link
Contributor Author

juju4 commented Feb 9, 2025

additional feedback? almalinux handling?
requested change has been done.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 16, 2025
@juju4
Copy link
Contributor Author

juju4 commented Feb 16, 2025

Most molecule fails seem because no python3-virtualenv on almalinux-9 but this depends on epel/cbr repository. should this be included in role, call external role, or something else? preference?

still valid question
per https://github.com/prometheus-community/ansible/actions/runs/13358242440/job/37304010121#step:3:2813 or https://github.com/prometheus-community/ansible/actions/runs/13358242440/job/37304012756#step:3:2437

gardar
gardar requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks and suggestions to make the virtualenv more dynamic across different distro versions

roles/pve_exporter/tasks/main.yml
Comment on lines +14 to +59
- name: Install
tags:
- pve_exporter_install
block:
- name: Install packages dependencies
ansible.builtin.package:
name:
- python3
- python3-pip
- python3-virtualenv
state: present
- name: "Create system group {{ pve_exporter_system_group }}"
ansible.builtin.group:
name: "{{ pve_exporter_system_group }}"
state: present
- name: "Create system user {{ pve_exporter_system_user }}"
ansible.builtin.user:
name: "{{ pve_exporter_system_user }}"
system: true
shell: "/usr/sbin/nologin"
group: "{{ pve_exporter_system_group }}"
home: "{{ pve_exporter_home }}"
create_home: true
become: true
- name: Install pve_exporter from pip
ansible.builtin.pip:
name: prometheus-pve-exporter
version: "{{ pve_exporter_version }}"
state: present
virtualenv: "{{ pve_exporter_virtualenv }}"
become: true
become_user: "{{ pve_exporter_system_user }}"
- name: Ensure config dir exists
ansible.builtin.file:
path: "{{ pve_exporter_config_dir }}"
state: directory
mode: '0775' # like _common
owner: root
- name: Configure pve_exporter
ansible.builtin.template:
src: "{{ pve_exporter_config_template }}"
dest: "{{ pve_exporter_config_dir }}/pve_exporter.yml"
mode: '0644'
owner: root
notify:
- Restart pve_exporter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the structure of the other roles and keep the install tasks in a separate tasks file.

roles/pve_exporter/tasks/main.yml
Comment on lines +25 to +37
- name: "Create system group {{ pve_exporter_system_group }}"
ansible.builtin.group:
name: "{{ pve_exporter_system_group }}"
state: present
- name: "Create system user {{ pve_exporter_system_user }}"
ansible.builtin.user:
name: "{{ pve_exporter_system_user }}"
system: true
shell: "/usr/sbin/nologin"
group: "{{ pve_exporter_system_group }}"
home: "{{ pve_exporter_home }}"
create_home: true
become: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the logic for creating the users from the _common role, where users are not modified if they do not exist, this is to prevent making changes to system users unexpectedly.

roles/pve_exporter/tasks/main.yml
- name: "Create system group {{ pve_exporter_system_group }}"
ansible.builtin.group:
name: "{{ pve_exporter_system_group }}"
state: present
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
state: present
state: present
become: true

roles/pve_exporter/tasks/main.yml
Comment on lines +18 to +24
- name: Install packages dependencies
ansible.builtin.package:
name:
- python3
- python3-pip
- python3-virtualenv
state: present
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make the python venv package install more dynamic like this:

Suggested change
- name: Install packages dependencies
ansible.builtin.package:
name:
- python3
- python3-pip
- python3-virtualenv
state: present
- name: Gather python facts
ansible.builtin.setup:
gather_subset:
- "!all"
- "python"
when:
"('python' not in ansible_facts) or
('discovered_interpreter_python' not in ansible_facts)
- name: Install packages dependencies
ansible.builtin.package:
name:
- "python{{ ansible_facts['ansible_python']['version']['major'] }}-setuptools"
- "python{{ ansible_facts['ansible_python']['version']['major'] }}-venv"
state: present
become: true

roles/pve_exporter/tasks/main.yml
name: prometheus-pve-exporter
version: "{{ pve_exporter_version }}"
state: present
virtualenv: "{{ pve_exporter_virtualenv }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
virtualenv: "{{ pve_exporter_virtualenv }}"
virtualenv: "{{ pve_exporter_virtualenv }}"
virtualenv_command: "{{ ansible_facts['discovered_interpreter_python'] }} -m venv"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardar gardar gardar requested changes

Assignees
No one assigned
Labels
enhancement New feature or request roles/pve_exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juju4 @gardar