Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prometheus_global values #520

Closed

Conversation

sugyan
Copy link
Contributor

@sugyan sugyan commented Jan 20, 2025

Although the value of prometheus_global says “It is compatible with the official configuration.”
It seems to be at variance with the default value described at https://prometheus.io/docs/prometheus/latest/configuration/configuration/#configuration-file.

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

@sugyan sugyan force-pushed the fix/prometheus_global branch from 664eda6 to bb66a9a Compare January 20, 2025 15:05
@github-actions github-actions bot added bugfix and removed bugfix labels Jan 20, 2025
@gardar gardar requested a review from SuperQ January 29, 2025 19:29
@gardar
Copy link
Member

gardar commented Feb 18, 2025

Any thoughts on this one @SuperQ ?

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it does differ from the example default configuration. This is a widely used configuration by many Prometheus deployments.

@SuperQ SuperQ closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants