Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add apache exporter #527

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

tbauriedel
Copy link
Contributor

@tbauriedel tbauriedel commented Feb 7, 2025

One of the most widely used web servers in the Linux environment is still Apache.

This PR adds the apache exporter
Exporter: https://github.com/Lusitaniae/apache_exporter

SideNote: I personally like the structure of the collection and the ability to add new roles with little effort.

@github-actions github-actions bot added enhancement New feature or request roles/apache_exporter and removed enhancement New feature or request labels Feb 7, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
@tbauriedel tbauriedel marked this pull request as draft February 7, 2025 10:03
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
@tbauriedel tbauriedel marked this pull request as ready for review February 7, 2025 10:15
Signed-off-by: Tobias Bauriedel <[email protected]>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please ensure you follow the tagging convention below (to be documented in the README soon):

  • Functional Tags: General-purpose tags for task behavior, e.g., download, install, configure, etc.
  • Role-Scoped Functional Tags: Combine the role name with a functional tag, e.g., <role_name>_download, <role_name>_install, etc.
  • Role-Wide Tags: Represent the entire role, e.g., <role_name>.

This structure allows for granular control, enabling you to target or skip tasks across all roles (e.g., all download tasks) or within a specific role (e.g., only <role_name>_download tasks).

SideNote: I personally like the structure of the collection and the ability to add new roles with little effort.

Glad you like it! Took a bit of brain power to get it to this stage :)

roles/apache_exporter/tasks/main.yml Outdated Show resolved Hide resolved
roles/apache_exporter/tasks/main.yml Outdated Show resolved Hide resolved
roles/apache_exporter/tasks/main.yml Outdated Show resolved Hide resolved
roles/apache_exporter/tasks/main.yml Outdated Show resolved Hide resolved
roles/apache_exporter/tasks/main.yml Outdated Show resolved Hide resolved
roles/apache_exporter/meta/argument_spec.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 8, 2025
Signed-off-by: Tobias Bauriedel <[email protected]>
@github-actions github-actions bot removed the enhancement New feature or request label Feb 8, 2025
@github-actions github-actions bot added the enhancement New feature or request label Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@tbauriedel tbauriedel requested a review from gardar February 8, 2025 14:22
@tbauriedel
Copy link
Contributor Author

All requested changes should be fixed. Thank you for your work on the collection!

roles/apache_exporter/tasks/main.yml Outdated Show resolved Hide resolved
Co-authored-by: gardar <[email protected]>
Signed-off-by: Tobias Bauriedel <[email protected]>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 11, 2025
@tbauriedel tbauriedel requested a review from gardar February 18, 2025 18:34
@gardar gardar merged commit d92f9e5 into prometheus-community:main Feb 18, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants