Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add enabled: true to alertmanager #530

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

sugyan
Copy link
Contributor

@sugyan sugyan commented Feb 8, 2025

Only in the alertmanager was there no written setting that would be enabled on boot.

$ for f in roles/*/tasks/main.yml; do grep -q 'enabled: true' $f || echo $f; done
roles/alertmanager/tasks/main.yml

@github-actions github-actions bot added the bugfix label Feb 8, 2025
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

Comment on lines 58 to 59
when:
- not ansible_check_mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The systemd module has full support for check_mode so I don't think this is needed

Suggested change
when:
- not ansible_check_mode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I've modified and pushed the part you suggested.

roles/alertmanager/tasks/main.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added bugfix and removed bugfix labels Feb 10, 2025
@sugyan sugyan requested a review from gardar February 10, 2025 14:32
@gardar gardar merged commit 4d26807 into prometheus-community:main Feb 18, 2025
50 checks passed
Copy link
Contributor

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants