[prometheus-mysql-exporter] add imagePullSecrets and fullname override (

#2905) * [prometheus-mysql-exporter] add imagePullSecrets and fullname override Signed-off-by: yaser <[email protected]> * [prometheus-mysql-exporter] add imagePullSecrets and fullname override add requested changes by reviewers Signed-off-by: yaser <[email protected]> Signed-off-by: yaser <[email protected]>
prometheus-community · Jan 11, 2023 · 5aabe31 · 5aabe31
1 parent 8a4bc9a
commit 5aabe31
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/charts/prometheus-mysql-exporter/Chart.yaml b/charts/prometheus-mysql-exporter/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v1
 description: A Helm chart for prometheus mysql exporter with cloudsqlproxy
 name: prometheus-mysql-exporter
-version: 1.11.1
+version: 1.12.1
 home: https://github.com/prometheus/mysqld_exporter
 appVersion: v0.14.0
 sources:

diff --git a/charts/prometheus-mysql-exporter/templates/deployment.yaml b/charts/prometheus-mysql-exporter/templates/deployment.yaml
@@ -30,11 +30,15 @@ spec:
       serviceAccountName: {{ template "prometheus-mysql-exporter.serviceAccountName" . }}
       securityContext:
         {{- toYaml .Values.podSecurityContext | nindent 8 }}
+      {{- if and .Values.imagePullSecrets }}
+      imagePullSecrets:
+        {{- toYaml .Values.imagePullSecrets | nindent 8 }}
+      {{- end }}
       containers:
         - name: {{ .Chart.Name }}
           securityContext:
             {{- toYaml .Values.securityContext | nindent 12 }}
-          image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
+          image: "{{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           {{- if or .Values.config .Values.collectors }}
           args:

diff --git a/charts/prometheus-mysql-exporter/values.yaml b/charts/prometheus-mysql-exporter/values.yaml
@@ -1,14 +1,22 @@
-# Default values for prometheus-mysql-exporter.
-# This is a YAML-formatted file.
-# Declare variables to be passed into your templates.
+## Default values for prometheus-mysql-exporter.
+## This is a YAML-formatted file.
+## Declare variables to be passed into your templates.
+
+## override release name
+fullnameOverride: ""
 
 replicaCount: 1
 
 image:
   repository: "prom/mysqld-exporter"
-  tag: "v0.14.0"
+  ## if not set charts appVersion var is used
+  tag: ""
   pullPolicy: "IfNotPresent"
 
+# imagePullSecrets:
+# - name: secret-name
+imagePullSecrets: []
+
 service:
   labels: {}
   annotations: {}