-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting different root dir for apt #178
base: master
Are you sure you want to change the base?
Conversation
Definitely needed to manage within a docker container. Suggest moving this forward. |
This PR is only managing it for the apt script. Do we need this setting for any of the other scripts in this code? A quick glance found deleted_libraries.py would require this change. fstab_check.sh. Gosh all of them? |
I've created an exporter using the script from this PR which runs inside a Kubernetes cluster inside a container exporting the metrics via |
should this be merged, or should we look at removing apt_info.py in favor of the apt-exporter? |
If we remove a script simply because a dedicated exporter exists, then we would also need to remove the smartmon.{py,sh} and ipmitool scripts. |
that would solve #119 at least :p |
Signed-off-by: egvimo <[email protected]>
See #171
Implemented as command line argument instead of env var.
Additionally I've refactored a little bit. Fixed linting issues and created a separate function to use in other scripts.