Smart status availability #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deezzir <[email protected]>
Signed-off-by: Deezzir <[email protected]>
Signed-off-by: Deezzir <[email protected]>
Deezzir
force-pushed
the
smart-status-availability
branch
from
798826f to
c2cce7b
Compare
robbat2
approved these changes
Jan 8, 2025
I believe so, so it is safe to merge |
robbat2
approved these changes
Jan 30, 2025
|
@robbat2 Can you please merge? |
I do not have merge permissions in this repo; I am just a frequent contributor. |
|
@SuperQ can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point in exporting
smartctl_device_smart_statusmetric for logical devices such as HW Raids if they do not support S.M.A.R.T. We can simply skip the metric if the objectsmart_statusis not present.Closes: #224
Closes: canonical/hardware-observer-operator#357