Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add card feature to msteamsv2_config #4243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jverger
Copy link

@jverger jverger commented Feb 3, 2025

The goal of this PR is to add an option card to the msteamsv2_config configuration.

If this card option is not used, the default behaviour is keept using title and text values.

Here is an example screenshot of the default result in msteams channel:
image

When using card option, the user is able to customize the msteams card rendering output by using a custom template file and configuring card option to use this template.

Here is an example screenshot of the output result in msteams channel when using card option:
image

To be honest, it's the first time i'm developing in go and create a PR.
Hope it will be not so bad :)

@jverger
Copy link
Author

jverger commented Feb 3, 2025

All checks have passed 🎉 , waiting for someone to merge this PR ⌚

@grobinson-grafana
Copy link
Contributor

I would really like to avoid pushing users towards templating JSON blobs. It has a lot of problems that I've explained in a couple other PRs such as #3799 (comment).

I think supporting cards would be excellent, because visually its a massive improvement, but just not with templated JSON.

@jverger
Copy link
Author

jverger commented Feb 3, 2025

Nevermind, I would have try.
Thank you for your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants