Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to java client documentation #2521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChrisMcD1
Copy link

I noticed some of these links were not working since the java client has moved their documentation from GitHub to their new docs site.

There are still 2 broken links that I did not fix in this PR because I could not find the corresponding new file.

https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/writing_exporters.md?plain=1#L350

and

https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/writing_exporters.md?plain=1#L387

But I figured it wouldn't hurt to make a PR for the ones that were trivial to fix!

I believe the CONTRIBUTING.md is asking me to ping the maintainers of the java client since the docs relate to their project, so @fstab @dhoard @tomwilkie

@ChrisMcD1
Copy link
Author

@RichiH This seems to fall under "everything else", so you seem appropriate to reach out to according to MAINTAINERS.md

@ChrisMcD1 ChrisMcD1 changed the title chore: Fix links to java client documentation Fix links to java client documentation Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant