Add collector for netstats tcp packet counters for FreeBSD. #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rin0913
force-pushed
the
master
branch
7 times, most recently
from
20a4ba5 to
4b51602
Compare
SuperQ
requested changes
Nov 10, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Signed-off-by: K Rin <[email protected]>
|
@SuperQ |
SuperQ
requested changes
Dec 10, 2024
Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: K Rin <[email protected]>
discordianfish
approved these changes
Jan 2, 2025
|
Hello, could you please merge this PR? Or there is anything I should work on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to extend network support for Prometheus node exporter on FreeBSD.
In this PR, I've added two counters to log the total TCP packets sent and received.
I hope everyone can discuss together whether this approach is feasible.