Move to yaml v3 #14886
Open
Move to yaml v3 #14886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roidelapluie
requested review from
dgl,
aknuds1,
jesusvazquez,
cstyan,
bwplotka,
tomwilkie and
juliusv
as code owners
Signed-off-by: Julien <[email protected]>
roidelapluie
force-pushed
the
yamlv3
branch
from
a3c3b9e to
97ff422
Compare
|
Tests are failing. |
|
Hello from the bug-scrub! Could you explain why we want v3, please? |
|
Seems, the only value of v3 is v2 EOL and perhaps less focus to scan v2 for vuln. Perhaps one thing is that v3 has support for comments though, which is nice in some areas. We hit similar in other places prometheus/client_golang#1579 Eventually, we have to move though. (: |
|
Citation for the EOL statement? |
|
Good point, only some mention that " Our BlackDuck scan shows gopkg.in/yaml.v2 version is EOLed". Can't find official EOL statement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.