-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Mollie Components #15
Comments
I checked the current status of this issue, but as it requires explicit integration with extensions (to first retrieve the token before submitting the checkout form) it might be better suited for a dedicated plugin integrating Mollie with WooCommerce? For example, code like this is not at home in this repository:
|
Discussed this today with @rvdsteege @pronamic HQ and we think this is a nice feature for Pronamic Pay 9.7. The specific WooCommerce code must be able to be edited out, for example by using We can also introduce a credit card field in core so that this field does not have to be constructed via JavaScript. We then only have to mount the Mollie components to the subfields of our core credit card field. |
It is more complex than expected, we have to look at the form handling per extension. For WooCommerce this can look like this: var WooCommerceCheckout = {
init: function() {
jQuery( 'form.woocommerce-checkout' ).on( 'checkout_place_order', WooCommerceCheckout.checkout_place_order );
},
checkout_place_order: function() {
var pronamicPayToken = PronamicPayToken( this );
pronamicPayToken.then(
function() {
jQuery( 'form.woocommerce-checkout' ).off( 'checkout_place_order', WooCommerceCheckout.checkout_place_order );
jQuery( 'form.woocommerce-checkout' ).submit();
}
);
return false;
}
}
WooCommerceCheckout.init(); Per extension we need a way to halt the form submit, request the Mollie token, and resubmit the form. Should we use promises for this? We could use https://www.npmjs.com/package/@wordpress/hooks to allow extensions or gateways to hook in. const pronamicPayTokenPromises = applyFilters( 'pronamicPayTokenPromises', [], this );
Promise.all( pronamicPayTokenPromises ).then(
function() {
// resubmit
}
); addFilter( 'pronamicPayTokenPromises', 'pronamic/wp-pronamic-pay-mollie', function( promises ) {
promises.push( mollie.createToken() );
} ); Should we name it |
@rvdsteege I have now created something that I am somewhat satisfied with. For now only with support for the legacy WooCommerce checkout form. PR is open for review: #40. We still need to add some styling and maybe improve error handling? Let's discuss @pronamic HQ tomorrow? wp-pronamic-pay-mollie/js/src/wc-legacy-checkout.js Lines 1 to 147 in aa3e3d3
|
From customer:
The text was updated successfully, but these errors were encountered: