Mollie components #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
============================================
+ Coverage 14.59% 15.86% +1.26%
- Complexity 467 482 +15
============================================
Files 19 21 +2
Lines 2110 2206 +96
============================================
+ Hits 308 350 +42
- Misses 1802 1856 +54 ☔ View full report in Codecov by Sentry. |
…onamic-pay-mollie into mollie-components
rvdsteege
approved these changes
Dec 6, 2023
src/Gateway.php
Outdated
|
|
||
| $profile_id = $profile->get_id(); | ||
|
|
||
| \set_transient( $cache_key, $profile_id, \DAY_IN_SECONDS ); |
There was a problem hiding this comment.
The Mollie profile won't change for a given API key. Are transients suitable in this case?
There was a problem hiding this comment.
Moved Mollie profile ID to configuration meta in 494e0be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.