feat: Check min amount out is not zero

Update tests --- don't change below this line --- ENG-4286 Took 57 minutes Took 20 seconds
propeller-heads · Mar 5, 2025 · 5c28d77 · 5c28d77
1 parent 9eb10e6
commit 5c28d77
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 31 deletions.
diff --git a/foundry/src/TychoRouter.sol b/foundry/src/TychoRouter.sol
@@ -63,6 +63,7 @@ error TychoRouter__AmountInDiffersFromConsumed(
 );
 error TychoRouter__MessageValueMismatch(uint256 value, uint256 amount);
 error TychoRouter__InvalidDataLength();
+error TychoRouter__UndefinedMinAmountOut();
 
 contract TychoRouter is AccessControl, Dispatcher, Pausable, ReentrancyGuard {
     IAllowanceTransfer public immutable permit2;
@@ -243,6 +244,10 @@ contract TychoRouter is AccessControl, Dispatcher, Pausable, ReentrancyGuard {
         if (receiver == address(0)) {
             revert TychoRouter__AddressZero();
         }
+        if (minAmountOut == 0) {
+            revert TychoRouter__UndefinedMinAmountOut();
+        }
+
         // Assume funds are already in the router.
         if (wrapEth) {
             _wrapETH(amountIn);