feat: Add Slither to CI #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make foundry workflow kebab case
tamaralipows
force-pushed
the
ci/tnl/ENG-4031-add-slither
branch
from
414df7f to
f0620bd
Compare
added 3 commits
January 17, 2025 16:39
Otherwise there will be no contract to analyze
Earlier versions have known vulnerabilities. Slither output: ``` INFO:Detectors: Version constraint ^0.8.13 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html) - VerbatimInvalidDeduplication - FullInlinerNonExpressionSplitArgumentEvaluationOrder - MissingSideEffectsOnSelectorAccess - StorageWriteRemovalBeforeConditionalTermination - AbiReencodingHeadOverflowWithStaticArrayCleanup - DirtyBytesArrayToStorage - InlineAssemblyMemorySideEffects - DataLocationChangeInInternalOverride - NestedCalldataArrayAbiReencodingSizeValidation. It is used by: - ^0.8.13 (src/Counter.sol#2) Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#incorrect-versions-of-solidity INFO:Slither:foundry/ analyzed (2 contracts with 93 detectors), 1 result(s) found ```
tamaralipows
force-pushed
the
ci/tnl/ENG-4031-add-slither
branch
from
a2c5bdc to
f987125
Compare
- Accidentally copy pasta'd
tamaralipows
force-pushed
the
ci/tnl/ENG-4031-add-slither
branch
from
c62c1a1 to
68dddc0
Compare
dianacarvalho1
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Veeeery niceee!! 🙏🏼 Thank you so much @tamaralipows ! This will be veeery useful for future us!
|
This PR is included in version 0.4.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slither automatically detects vulnerabilities in our solidity smart contracts.
This tool was recommended by Max in the last audit.
It now automatically runs in the CI, we have instructions to run it locally, and our first issue is fixed: Solidity version with known vulnerabilities (see commit for more details).