feat: Support cyclic swaps #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royvardhan
force-pushed
the
router/hr/ENG-4290-cyclic-swap
branch
2 times, most recently
from
b4154b6 to
8fe9c4f
Compare
royvardhan
changed the title
royvardhan
force-pushed
the
router/hr/ENG-4290-cyclic-swap
branch
from
8fe9c4f to
5577b5a
Compare
royvardhan
changed the title
tamaralipows
requested changes
Mar 6, 2025
There was a problem hiding this comment.
thank you @royvardhan ! Can we improve the PR name a bit please? the first part of the name doesn't mean much without more context. it should be a feat and something like: feat: Support cyclic swaps
royvardhan
changed the title
… add testCyclicSwapWithTwoPools test to verify
royvardhan
force-pushed
the
router/hr/ENG-4290-cyclic-swap
branch
from
62a66ff to
ecf425a
Compare
tamaralipows
reviewed
Mar 6, 2025
royvardhan
force-pushed
the
router/hr/ENG-4290-cyclic-swap
branch
from
c29eaea to
ae99f80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding a cyclic swap test, I discovered that we are adding the
amountIntoamountOutwhentokenInIndexandtokenOutIndexare same. I added acyclicSwapAmountOuttracker to trackamountOutin case of cyclic swap, and added both sequential and split swap tests that circles back to USDC(the start token of the swap)