refactor(simulation-py): make price() function optional
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvinagre
force-pushed
the
zz/python-sim/make-price-optional
branch
2 times, most recently
from
68f03c8 to
348cf51
Compare
tvinagre
force-pushed
the
zz/python-sim/make-price-optional
branch
from
348cf51 to
574847d
Compare
tvinagre
approved these changes
Feb 7, 2025
| @@ -166,28 +166,53 @@ def _set_engine(self): | |||
| self._engine = engine | |||
|
|
|||
| def _set_marginal_prices(self): | |||
| """Set the spot prices for this pool. | |||
| """Set the spot prices for this pool.""" | |||
There was a problem hiding this comment.
Can you add more docs on this? There are important design decisions that led to this implementation
|
This PR is included in version 0.74.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.