feat: add account balance overrides #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louise-poole
force-pushed
the
lp/account-balance-overrides
branch
from
fbe8aa6 to
8017af2
Compare
zizou0x
reviewed
Feb 6, 2025
louise-poole
force-pushed
the
lp/account-balance-overrides
branch
from
8017af2 to
de04d29
Compare
louise-poole
changed the base branch from
main
to
lp/update-on-account-changes
louise-poole
commented
Feb 12, 2025
zizou0x
reviewed
Feb 13, 2025
|
I noticed a lot of missing/not updated docs, would be nice to double check that we keep everything up to date before merging |
louise-poole
commented
Feb 13, 2025
| @@ -48,23 +48,42 @@ impl TryFromWithBlock<ComponentWithState> for EVMPoolState<PreCachedDB> { | |||
| async fn try_from_with_block( | |||
| snapshot: ComponentWithState, | |||
| block: Header, | |||
| account_balances: &HashMap<Bytes, HashMap<Bytes, Bytes>>, | |||
There was a problem hiding this comment.
Idea: We could refactor our try_from_with_block to decode whole Snapshots instead of ComponentWithState (like the python version). Then we'd have the account balances inside the snapshot and don't need to collect and pass it extra like this.
There was a problem hiding this comment.
Yes, that'd be the cleaner way. Can we do this in a separate PR?
There was a problem hiding this comment.
But it means we pass a lot more data in the interface: The full snapshot has the full vm_storage with it which include storage slots, contract code etc.
louise-poole
force-pushed
the
lp/account-balance-overrides
branch
from
23d5fc9 to
5f28bff
Compare
kayibal
reviewed
Feb 13, 2025
louise-poole
force-pushed
the
lp/update-on-account-changes
branch
from
a551ec5 to
33284ad
Compare
For protocols with specified balance owners with tracked account balances, we should use those balances instead of component balances.
And update overwrites logic to handle both component balances and contract balances.
louise-poole
force-pushed
the
lp/account-balance-overrides
branch
from
289fd31 to
6eb24d5
Compare
regardless of if there is an associated contract/attribute change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some protocols the balances used by a component is stored on a separate contract. To best cater for such components we now support using account_balances where the balance for relevant contracts is monitored and overwritten during simulation.
Decisions: