feat: Configurable chain in quickstart #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianacarvalho1
force-pushed
the
execution/dc/ENG-4088-improve-quickstart
branch
2 times, most recently
from
28d8905 to
81fe59a
Compare
Base automatically changed from
execution/dc/ENG-4088-improve-quickstart
to
main
February 27, 2025 15:18
tamaralipows
force-pushed
the
execution/tnl/ENG-4271-base-quickstart
branch
from
043c6de to
2b1e513
Compare
- Tested for execution on Base - all good.
tamaralipows
force-pushed
the
execution/tnl/ENG-4271-base-quickstart
branch
from
2b1e513 to
9b1e03e
Compare
- Need this for the latest executor addresses
tamaralipows
commented
Feb 28, 2025
tamaralipows
commented
Feb 28, 2025
tamaralipows
commented
Feb 28, 2025
added 3 commits
February 28, 2025 13:22
- Excluding Balancer V2 since it's not supported on tycho indexer for base - Also get rid of the base hardcoding when creating txs and provider. Get this from the cli input
Tested that all still works properly.
tamaralipows
force-pushed
the
execution/tnl/ENG-4271-base-quickstart
branch
from
5d5fb3f to
9d29ab6
Compare
tamaralipows
changed the title
added 3 commits
February 28, 2025 14:16
We support multiple chains so this may not just be ETH, but perhaps a Base URL for example. It now matched tycho-execution.
dianacarvalho1
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Thank you so much @tamaralipows 🙏🏼 only have tiny tiny requests!
|
This PR is included in version 0.80.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.