Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: miscellaneous fixes in the price printer example and evm Tycho decoder #163

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

zizou0x
Copy link
Contributor

@zizou0x zizou0x commented Mar 6, 2025

This PR fixes two bugs:

  1. In the price printer example it fixes a bug where the amount would become 0 if there was a negative decimals difference between previous and current token in
  2. In the Tycho decoder it fixes a bug where wrong insertions were made into the contracts_map leading to panics

zizou0x added 2 commits March 6, 2025 12:44
Fix a bug where the amount would become 0 if there was a negative decimals difference between previous and current token in.
This commit fixes a bug where wrong insertions were made into the `contracts_map`.

Also make the value of this map a `HashSet` for optimization.
@zizou0x zizou0x merged commit 9049d5a into main Mar 6, 2025
3 checks passed
@zizou0x zizou0x deleted the zz/example-and-decoder-fixes branch March 6, 2025 16:33
@propellerci
Copy link

propellerci bot commented Mar 6, 2025

This PR is included in version 0.82.1 🎉

@propellerci propellerci bot added the true label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants