Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement get_code_for_address util function #4

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feat: implement get_code_for_address util function #4

merged 2 commits into from
Oct 17, 2024

Conversation

louise-poole
Copy link
Contributor

@louise-poole louise-poole commented Oct 15, 2024 •
edited
Loading

tamaralipows
tamaralipows reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@tamaralipows tamaralipows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks pretty spot-on comparing with the python side I think.

I have one question/doubt that is exactly the same question on my PR:
Should we also make the python package now use this method instead of re-implementing it in there?

@louise-poole
Copy link
Contributor Author

I have one question/doubt that is exactly the same question on my PR: Should we also make the python package now use this method instead of re-implementing it in there?

In the long run yes. But for now to quote Alan:

I wouldn’t do this now - it’s probably better to duplicate all for now, then later decide where we want the interface to be and potentially move it up - the interface is very low-level atm (around SimulationEngine). It probably makes sense to place it around the ProtocolSim trait somewhere.

@louise-poole louise-poole force-pushed the lp/ENG-3747-implement-get-code-util branch from 170fa60 to 1fa43d4 Compare October 17, 2024 09:53
tamaralipows
tamaralipows approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@tamaralipows tamaralipows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@louise-poole louise-poole force-pushed the lp/ENG-3747-implement-get-code-util branch from 509f793 to 11da09a Compare October 17, 2024 14:16
@louise-poole louise-poole force-pushed the lp/ENG-3747-implement-get-code-util branch from 11da09a to 6c75b26 Compare October 17, 2024 14:16
@louise-poole louise-poole merged commit 4429d1c into main Oct 17, 2024
3 checks passed
@propellerci
Copy link

propellerci bot commented Oct 17, 2024

This PR is included in version 0.22.0 🎉

@propellerci propellerci bot added the true label Oct 17, 2024
@louise-poole louise-poole deleted the lp/ENG-3747-implement-get-code-util branch October 17, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamaralipows tamaralipows tamaralipows approved these changes

Assignees
No one assigned
Labels
true
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louise-poole @tamaralipows