Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixed issues related to MSSQL #1431

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

atompulse
Copy link
Contributor

We are working on a project using MSSQL so I was forced to tackle these issues:

#1294
#1343

MSSQL - Uncaught 'PDOException' - "attribute only supported on PDOStatement object"
propelorm#1294
propelorm#1343
Solved:
- size checking issue
- default values issue
- foreign keys actions (on delete/on update)
Remaining:
- sql syntax for alter table
- alter multiple columns
- create/drop (unique) indexes
MSSQL - Uncaught 'PDOException' - "attribute only supported on PDOStatement object"
propelorm#1294
propelorm#1343
Solved:
- size checking issue
- default values issue
- foreign keys actions (on delete/on update)
Remaining:
- sql syntax for alter table
- alter multiple columns
- create/drop (unique) indexes
@@ -786,7 +786,7 @@ public function setupReferrers($throwErrors = false)

// check for incomplete foreign key references when foreign table
// has a composite primary key
if ($foreignTable->hasCompositePrimaryKey()) {
if (!is_null($foreignTable) && $foreignTable->hasCompositePrimaryKey()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as it fixes this specific case

@atompulse atompulse changed the title Fixed issues related to MSSQL [WIP] Fixed issues related to MSSQL Nov 23, 2017
@dereuromark
Copy link
Contributor

Can you rebase on top of latest master?
Then we can proceed.

@dereuromark dereuromark added the Bug label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants