Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving related objects #1485

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ppatrik
Copy link

@ppatrik ppatrik commented Jun 27, 2018

TODO's:
Modifing in addRelatedObject, clearRelatedObjects, etc. needs to be tested and fully implemented.

* Archivable behaviour with FK customization.

Added two boolan parameters:
* archive_foreign_keys (default: false) - on true FK will be copied to Archive table class, so API for archive and non-archive class is the same.
* archive_foreign_keys_skip_sql (default: true) - same API is enought so database FK will be skiped by default.

* Fixed parameter checks.
Property modifiedColumns is changed after adding/changing related objects.
@dereuromark dereuromark added the Bug label Jul 7, 2020
@dereuromark
Copy link
Contributor

Is there any test case for this maybe?

Copy link
Contributor

@Incognito Incognito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR Deprecate #1484 ?

@dereuromark
Copy link
Contributor

Deprecate? you mean replace, right?

@Incognito
Copy link
Contributor

Incognito commented Jul 13, 2020

Supersede.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants