criteria uses named joins internally #1977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 4, 2023 17:01
It already has a named Api, using auto indexes breaks ModelCriteria where
mmeisso
force-pushed
the
criteria-uses-named-joins
branch
from
4a97e12
to
85dbe48
Compare
This reverts commit 0e48855.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Criteria's joins ( from addJoin ) does not uses named joins, unlike... Criteria's joins.
There is a brain split at some time, where it exposes
public function getJoin(string $name): Join, public methods that can never work on a raw Criteria instance that never put a name on these joins.#1919