use parent:: instead of ModelCritera:: #2016
Conversation
As recommended in php docs http://php.adamharvey.name/manual/en/keyword.parent.php Propel/Propel2 Issue 2009
Causing test to fail and doesn't add anything. bostore_contest.id is already in there, unique, and primary key.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## master #2016 +/- ##
=============================================
- Coverage 89.25% 73.97% -15.28%
Complexity 8065 8065
=============================================
Files 232 232
Lines 24550 24550
=============================================
- Hits 21911 18161 -3750
- Misses 2639 6389 +3750
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -89,7 +89,6 @@ | |||
| <reference local="customer_id" foreign="id"/> | |||
| </foreign-key> | |||
| <foreign-key foreignTable="bookstore_contest" onDelete="cascade"> | |||
| <reference local="bookstore_id" foreign="bookstore_id"/> | |||
There was a problem hiding this comment.
@rizwanjiwan What was your reasoning to remove this? This apparently made the CI error go away, but I'm wondering what you figured out about it.
As recommended in php docs http://php.adamharvey.name/manual/en/keyword.parent.php
#2009