Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update Golang to version 1.23.1 #82

Merged

Conversation

devon-manifest
Copy link
Contributor

Remediates a number of vulnerabilities in Golang stdlib for versions < 1.23.1

Copy link
Collaborator

@manifestori manifestori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR

please check my comments

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@devon-manifest devon-manifest force-pushed the devon-manifest/golang-update-1.23.1 branch from ec46b2f to 221896f Compare October 1, 2024 13:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
cmd/cli/convert.go 0.00% <ø> (ø)
cmd/cli/root.go 0.00% <ø> (ø)

... and 9 files with indirect coverage changes

@devon-manifest
Copy link
Contributor Author

devon-manifest commented Oct 1, 2024

thanks for the PR

please check my comments

Requested changes made.
Integer overflow issue also fixed (thanks @manifestori !)

@devon-manifest devon-manifest requested a review from cpanato October 1, 2024 13:31
@devon-manifest
Copy link
Contributor Author

@cpanato any additional follow-ups or are we okay to get this merged in?

.github/workflows/lint.yml Outdated Show resolved Hide resolved
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a tiny comment

Co-authored-by: Carlos Tadeu Panato Junior <[email protected]>
@devon-manifest
Copy link
Contributor Author

a tiny comment

Updated

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@cpanato cpanato merged commit 1f5cfd0 into protobom:main Oct 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants