Skip to content

Commit

Permalink
Fix reference to jsoncpp.BUILD and zlib.BUILD. Colon was in wrong pla…
Browse files Browse the repository at this point in the history
…ce, because there's a BUILD file in third_party.

Export jsoncpp.BUILD. Otherwise the file can't be used from another package.

The problem was detected by Bazel 8 in WORKSPACE mode. This should be cherry-picked to 29. release.

PiperOrigin-RevId: 691587110
  • Loading branch information
protobuf-github-bot authored and copybara-github committed Oct 30, 2024
1 parent 99e35c0 commit 163cff9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions protobuf_deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def protobuf_deps():
if not native.existing_rule("zlib"):
http_archive(
name = "zlib",
build_file = Label("//:third_party/zlib.BUILD"),
build_file = Label("//third_party:zlib.BUILD"),
sha256 = "38ef96b8dfe510d42707d9c781877914792541133e1870841463bfa73f883e32",
strip_prefix = "zlib-1.3.1",
urls = [
Expand All @@ -84,7 +84,7 @@ def protobuf_deps():
repo = "https://github.com/open-source-parsers/jsoncpp",
commit = "89e2973c754a9c02a49974d839779b151e95afd6", # 1.9.6
sha256 = "02f0804596c1e18c064d890ac9497fa17d585e822fcacf07ff8a8aa0b344a7bd",
build_file = Label("//:third_party/jsoncpp.BUILD"),
build_file = Label("//third_party:jsoncpp.BUILD"),
)

if not native.existing_rule("rules_cc"):
Expand Down
1 change: 1 addition & 0 deletions third_party/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
exports_files([
"BUILD.bazel",
"jsoncpp.BUILD",
"rules_fuzzing.patch",
"zlib.BUILD",
])

0 comments on commit 163cff9

Please sign in to comment.