Skip to content

Commit

Permalink
Fix PHP package.xml generation to generate correct github link to rel…
Browse files Browse the repository at this point in the history
…ease notes using protoc_version formatted with -rcN instead of -rc-N.

Fixes #18979

PiperOrigin-RevId: 690643390
  • Loading branch information
zhangskz authored and copybara-github committed Oct 28, 2024
1 parent 654048b commit 9e10b7c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion php/ext/google/protobuf/generate_package_xml.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ sed -e "s;TEMPLATE_TIME;${time};" |
sed -e "s;TEMPLATE_PHP_RELEASE;${release_version};" |
sed -e "s;TEMPLATE_PHP_API;${api_version};" |
sed -e "s;TEMPLATE_PHP_STABILITY;${stability};g" |
sed -e "s;TEMPLATE_PROTOC_VERSION;${protoc_version};" |
sed -e "s;TEMPLATE_PROTOC_VERSION;${protoc_version//-rc-/-rc};" |
sed -e "s;TEMPLATE_FILES;${files};" > $out

0 comments on commit 9e10b7c

Please sign in to comment.