Emit setters on primitive scalars without presence

PiperOrigin-RevId: 589840802
protocolbuffers · Dec 11, 2023 · d605b48 · d605b48
1 parent f85b347
commit d605b48
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/rust/test/shared/accessors_proto3_test.rs b/rust/test/shared/accessors_proto3_test.rs
@@ -26,6 +26,10 @@ fn test_fixed32_accessors() {
     msg.optional_fixed32_mut().set(u32::default());
     assert_that!(msg.optional_fixed32(), eq(0));
     assert_that!(msg.optional_fixed32_mut().get(), eq(0));
+
+    msg.optional_fixed32_set(43);
+    assert_that!(msg.optional_fixed32(), eq(43));
+    assert_that!(msg.optional_fixed32_mut().get(), eq(43));
 }
 
 #[test]
@@ -41,6 +45,10 @@ fn test_bool_accessors() {
     msg.optional_bool_mut().set(bool::default());
     assert_that!(msg.optional_bool(), eq(false));
     assert_that!(msg.optional_bool_mut().get(), eq(false));
+
+    msg.optional_bool_set(true);
+    assert_that!(msg.optional_bool(), eq(true));
+    assert_that!(msg.optional_bool_mut().get(), eq(true));
 }
 
 #[test]

diff --git a/src/google/protobuf/compiler/rust/accessors/singular_scalar.cc b/src/google/protobuf/compiler/rust/accessors/singular_scalar.cc
@@ -61,6 +61,12 @@ void SingularScalar::InMsgImpl(Context<FieldDescriptor> field) const {
                     }
                   }
                 )rs");
+             } else {
+               field.Emit({}, R"rs(
+                 pub fn r#$field$_set(&mut self, val: $Scalar$) {
+                   unsafe { $setter_thunk$(self.inner.msg, val) }
+                 }
+               )rs");
              }
            }},
           {"field_mutator_getter",