Skip to content

Commit

Permalink
upb: clean up and consolidate the upb/message/ build targets
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 594167226
  • Loading branch information
ericsalo authored and copybara-github committed Dec 28, 2023
1 parent e0b3610 commit f9e037c
Show file tree
Hide file tree
Showing 39 changed files with 237 additions and 283 deletions.
3 changes: 1 addition & 2 deletions protos/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ cc_library(
"//upb:mem",
"//upb:message",
"//upb:message_copy",
"//upb:message_types",
"@com_google_absl//absl/base:core_headers",
"@com_google_absl//absl/strings",
],
Expand All @@ -59,10 +58,10 @@ cc_library(
"//upb:message_accessors",
"//upb:message_copy",
"//upb:message_promote",
"//upb:message_types",
"//upb:mini_table",
"//upb:wire",
"//upb:wire_reader",
"//upb/message:internal",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings",
Expand Down
2 changes: 1 addition & 1 deletion protos/protos.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
#include "upb/mem/arena.h"
#include "upb/message/copy.h"
#include "upb/message/internal/extension.h"
#include "upb/message/message.h"
#include "upb/message/promote.h"
#include "upb/message/types.h"
#include "upb/mini_table/extension.h"
#include "upb/mini_table/extension_registry.h"
#include "upb/mini_table/message.h"
Expand Down
2 changes: 1 addition & 1 deletion protos/repeated_field.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include "upb/mem/arena.h"
#include "upb/message/array.h"
#include "upb/message/copy.h"
#include "upb/message/types.h"
#include "upb/message/message.h"

namespace protos {
namespace internal {
Expand Down
2 changes: 1 addition & 1 deletion protos/repeated_field_iterator.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "upb/base/string_view.h"
#include "upb/mem/arena.h"
#include "upb/message/array.h"
#include "upb/message/types.h"
#include "upb/message/message.h"

namespace protos {
namespace internal {
Expand Down
31 changes: 4 additions & 27 deletions upb/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ cc_library(
":mini_descriptor",
":mini_table",
":wire",
"//upb/message:internal",
],
)

Expand Down Expand Up @@ -234,24 +235,6 @@ alias(
visibility = ["//visibility:public"],
)

alias(
name = "message_tagged_ptr",
actual = "//upb/message:tagged_ptr",
visibility = ["//upb:friends"],
)

alias(
name = "message_types",
actual = "//upb/message:types",
visibility = ["//visibility:public"],
)

alias(
name = "message_value",
actual = "//upb/message:value",
visibility = ["//visibility:public"],
)

alias(
name = "mini_descriptor",
actual = "//upb/mini_descriptor",
Expand Down Expand Up @@ -370,9 +353,6 @@ upb_amalgamation(
":message_accessors",
":message_compare",
":message_copy",
":message_tagged_ptr",
":message_types",
":message_value",
":mini_descriptor",
":mini_descriptor_internal",
":mini_table",
Expand All @@ -383,6 +363,7 @@ upb_amalgamation(
":wire",
":wire_reader",
"//upb/mem:internal",
"//upb/message:internal",
"//upb/mini_table:internal",
],
strip_import_prefix = ["src"],
Expand Down Expand Up @@ -418,9 +399,6 @@ upb_amalgamation(
":message_accessors",
":message_compare",
":message_copy",
":message_tagged_ptr",
":message_types",
":message_value",
":mini_descriptor",
":mini_descriptor_internal",
":mini_table",
Expand All @@ -431,6 +409,7 @@ upb_amalgamation(
":wire",
":wire_reader",
"//upb/mem:internal",
"//upb/message:internal",
"//upb/mini_table:internal",
],
prefix = "php-",
Expand Down Expand Up @@ -467,9 +446,6 @@ upb_amalgamation(
":message_accessors",
":message_compare",
":message_copy",
":message_tagged_ptr",
":message_types",
":message_value",
":mini_descriptor",
":mini_descriptor_internal",
":mini_table",
Expand All @@ -480,6 +456,7 @@ upb_amalgamation(
":wire",
":wire_reader",
"//upb/mem:internal",
"//upb/message:internal",
"//upb/mini_table:internal",
],
prefix = "ruby-",
Expand Down
2 changes: 0 additions & 2 deletions upb/json/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ cc_library(
"//upb:lex",
"//upb:mem",
"//upb:message",
"//upb:message_types",
"//upb:mini_table",
"//upb:port",
"//upb:reflection",
Expand Down Expand Up @@ -101,7 +100,6 @@ upb_c_proto_library(
# "//upb:base",
# "//upb:mem",
# "//upb:message",
# "//upb:message_types",
# "//upb:mini_table",
# "//upb:reflection",
# ],
Expand Down
1 change: 0 additions & 1 deletion upb/json/decode.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include "upb/message/array.h"
#include "upb/message/map.h"
#include "upb/message/message.h"
#include "upb/message/types.h"
#include "upb/mini_table/message.h"
#include "upb/reflection/def.h"
#include "upb/reflection/message.h"
Expand Down
Loading

0 comments on commit f9e037c

Please sign in to comment.