Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NewStringElement inlining. #15130

Merged
0 commits merged into from
Dec 19, 2023
Merged

Allow NewStringElement inlining. #15130

0 commits merged into from
Dec 19, 2023

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Dec 18, 2023

Allow NewStringElement inlining.

name                                   old INSTRUCTIONS/op     new INSTRUCTIONS/op     delta
BM_RepeatedPtrField_Ctor                  251 ± 0%                251 ± 0%     ~     (all samples are equal)
BM_RepeatedPtrField_Add_Sso              84.8 ± 2%               76.7 ± 2%   -9.51%      (p=0.000 n=100+100)
BM_RepeatedPtrField_Add_FallbackToRep     215 ± 5%                199 ± 5%   -7.26%       (p=0.000 n=100+99)
BM_RepeatedPtrField_Add_Small             163 ± 1%                157 ± 1%   -3.96%      (p=0.000 n=100+100)
BM_RepeatedPtrField_Add_Large            96.7 ± 1%               90.7 ± 1%   -6.13%      (p=0.000 n=100+100)
BM_RepeatedPtrField_Add_HasCleared       36.5 ± 0%               36.5 ± 0%     ~           (p=0.314 n=76+79)
BM_RepeatedPtrField_AddAllocated         30.5 ± 0%               30.6 ± 1%     ~           (p=0.109 n=78+93)
BM_RepeatedPtrField_Sort                49.5k ± 0%              49.5k ± 0%   +0.12%        (p=0.000 n=80+95)
BM_RepeatedPtrField_SortIndirect          559 ± 0%                561 ± 6%     ~           (p=0.203 n=76+81)

@copybara-service copybara-service bot closed this Dec 19, 2023
@copybara-service copybara-service bot closed this pull request by merging all changes into main in 1427a85 Dec 19, 2023
@copybara-service copybara-service bot deleted the test_591892608 branch December 19, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants