Update lite_unittest to pad varints before calling internal::VarintParse()
#15151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…arse()` The `VarintParse()` function is ordinarily called only by the proto parser, which always provides 16 bytes of "slop" space at the end of the buffer. The ARM-specific optimized path takes advantage of this by always reading at least 8 bytes. However, this caused some test failures in msan due to unit tests not providing a sufficient amount of initialized padding. This CL fixes the problem by making sure the unit tests initialize the full 10-byte buffer and adding a comment stating that this is a precondition of the function. PiperOrigin-RevId: 592366291
copybara-service
bot
force-pushed
the
test_592344313
branch
from
9891883
to
bc66a18
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
bc66a18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lite_unittest to pad varints before calling
internal::VarintParse()The
VarintParse()function is ordinarily called only by the proto parser,which always provides 16 bytes of "slop" space at the end of the buffer. The
ARM-specific optimized path takes advantage of this by always reading at least
8 bytes. However, this caused some test failures in msan due to unit tests not
providing a sufficient amount of initialized padding. This CL fixes the problem
by making sure the unit tests initialize the full 10-byte buffer and adding a
comment stating that this is a precondition of the function.