Cherry-picks for Bazel 8 #18820
Merged
Cherry-picks for Bazel 8 #18820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename bazel_osx_p4deps to for_bazel_tests. The name was used in the past. Fix all bzl_libraries to have the correct set of dependencies. Cleanup for_bazel_tests to include BUILD file and public bzl_libraries in the package. PiperOrigin-RevId: 684713554
Bazel 8's autoloads don't work in repositories where they load from. Protobuf thus needs to load Python rules. PiperOrigin-RevId: 685703304
comius
force-pushed
the
prepare-for-bazel-8
branch
from
1c63e5a
to
f77e272
Compare
Autoloads don't work in repositories where they load from. Protobuf thus needs to have Shell loads. PiperOrigin-RevId: 684493665
Without it the still slightly weird setup of Bazel unit tests causes problems. PiperOrigin-RevId: 684391633
This version is compatible with Bazel 6 and above. PiperOrigin-RevId: 684107925
comius
force-pushed
the
prepare-for-bazel-8
branch
from
f77e272
to
3dd4835
Compare
Nice to have in the future when rules_cc are in the repository, but not necessary ATM. PiperOrigin-RevId: 674352147
zhangskz
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
zhangskz
reviewed
Oct 15, 2024
|
We also still need another change to remove |
Perhaps let's do this as a separate PR? I still need to prepare a patch release of rules_java, it will take a couple of days. |
PiperOrigin-RevId: 686572636
zhangskz
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits:
9c4f3b8 Prepare supporting targets for testing
b00dca3 Load Python rules everywhere in protobuf
5aa7abc Upgrade rules_cc to 0.0.13
8ec13ed Load Shell rules everywhere in protobuf
a0eb240 Replace use of C++17 with disabling a warning
Pending commits:
a038509 Convert proto toolchain string to Label (cl/684391633)
f484e9c Use rules_cc everywhere in protobuf (cl/674352147)