Implement relay with builder REST API spec #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/master: use upstream payload ID switch to geth types
Co-authored-by: Chris Hager <[email protected]> Co-authored-by: lightclient <[email protected]>
lightclient
approved these changes
May 11, 2022
| BlockHash common.Hash `json:"blockHash" gencodec:"required"` | ||
| TransactionsRoot common.Hash `json:"transactionsRoot" gencodec:"required"` | ||
| } | ||
| func BuilderGetHeader(ctx context.Context, log logrus.Ext1FieldLogger, sk bls.SecretKey, builderAddr string, blockHash common.Hash) (*types.ExecutionPayloadHeader, error) { |
There was a problem hiding this comment.
Suggested change
| func BuilderGetHeader(ctx context.Context, log logrus.Ext1FieldLogger, sk bls.SecretKey, builderAddr string, blockHash common.Hash) (*types.ExecutionPayloadHeader, error) { | |
| func BuilderGetHeader(ctx context.Context, log logrus.Ext1FieldLogger, builderAddr string, slot uint64, blockHash common.Hash, sk bls.SecretKey) (*types.ExecutionPayloadHeader, error) { |
Needs slot parameter. Also makes sense to order in the same order they are in the path.
| ExtraData hexutil.Bytes | ||
| LogsBloom hexutil.Bytes | ||
| } | ||
| path := fmt.Sprintf("/eth/v1/builder/header/%d/%s/0x%x", 1, blockHash.Hex(), sk.PublicKey().Marshal()) |
There was a problem hiding this comment.
Suggested change
| path := fmt.Sprintf("/eth/v1/builder/header/%d/%s/0x%x", 1, blockHash.Hex(), sk.PublicKey().Marshal()) | |
| path := fmt.Sprintf("/eth/v1/builder/header/%d/%s/0x%x", slot, blockHash.Hex(), sk.PublicKey().Marshal()) |
| type BlindedBeaconBlockBody struct { | ||
| ExecutionPayload ExecutionPayloadHeaderV1 `json:"execution_payload_header"` | ||
| e.Debug("Received payload") | ||
| return bid.Data.Message.Header, nil |
There was a problem hiding this comment.
Should probably verify builder signature before returning. Maybe also add a TODO that we should eventually add a list of "trusted" builders to cross-reference the builder pubkey against.
| Message *BuilderReceipt `json:"message"` | ||
| Signature string `json:"signature"` | ||
| } | ||
| func BuilderGetPayload(ctx context.Context, log logrus.Ext1FieldLogger, sk bls.SecretKey, builderAddr string, header *types.ExecutionPayloadHeader) (*types.ExecutionPayloadV1, error) { |
There was a problem hiding this comment.
The api interface probably shouldn't take bls.SecretKey, rather SignedBlindedBeaconBlock instead.
| } | ||
|
|
||
| // func (r *RelayBackend) GetHeaderV1(ctx context.Context, slot hexutil.Uint64, pubkey hexutil.Bytes, parentHash common.Hash) (*types.SignedBuilderBidV1, error) { |
There was a problem hiding this comment.
Can probably just remove this stuff now?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum/builder-specs#2 + https://ethereum.github.io/builder-specs/