add country-coder json [#44]

[bdon]

@wipfli @nvkelso

[wipfli]

You might want to use Planetiler's PolygonIndex, see https://github.com/onthegomap/planetiler/blob/f5fe38a4d4400f3aa30998a1eb3ac551ce3e47d9/planetiler-core/src/main/java/com/onthegomap/planetiler/geo/PolygonIndex.java#L20, cc @msbarry

[bdon]

We may need to enhance that to handle (Polygon contains LineString) - looks like Contains only supports Point and Intersects works for all geometries? TBD if it actually matters

[msbarry]

I was thinking about that, it seems like country coder should return the country that feature is "most within" so we could sample a few points? Here's the api that prepared geometry exposes when testing geometries: https://locationtech.github.io/jts/javadoc/org/locationtech/jts/geom/prep/PreparedGeometry.html

[sonarcloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[msbarry]

FYI I'm planning to add something very similar to planetiler soon to support name abbreviations and other use cases like this: onthegomap/planetiler#14 (comment)

[bdon]

@msbarry great, I could upstream this implementation or merge it with PolygonIndex once it's proven out, unless you see any major things missing? Biggest TBD feels like what happens at boundaries

[msbarry]

@msbarry great, I could upstream this implementation or merge it with PolygonIndex once it's proven out, unless you see any major things missing? Biggest TBD feels like what happens at boundaries

That would be great! My plan was to eventually have configurable backends that require downloading different data sources (natural earth borders by POV or overture divisions) but the fallback would be to use this country-coder json source bundled in the jar.

[bdon]

There are also some data cleanup needed on the JSON like a separate country code FX for Metropolitan France.
I think country-coder is good enough for Shields since although US states aren't in the JSON the OSM tags may have enough state network information to derive that.