Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid variable shadowing in house number code #392

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Avoid variable shadowing in house number code #392

merged 1 commit into from
Feb 24, 2025

Conversation

wipfli
Copy link
Collaborator

@wipfli wipfli commented Feb 24, 2025

No functional change, just avoid shadowing the variable feature in the buildings layer.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wipfli
Copy link
Collaborator Author

wipfli commented Feb 24, 2025

Ok actually this the current code does not shadow the feature variable. But I still find it a bit easier to read this way...

@bdon bdon merged commit 450155a into protomaps:main Feb 24, 2025
5 checks passed
@wipfli wipfli deleted the avoid-variable-shadowing branch February 24, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wipfli @bdon