Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #329

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Fix CI #329

merged 8 commits into from
Dec 9, 2024

Conversation

toolCHAINZ
Copy link
Contributor

@toolCHAINZ toolCHAINZ commented Dec 2, 2024

Three things in this MR:

  • Fix the WASM build by pinning cc to 1.1 (see WASM Build Failure #328 for details).
  • Fix the existing "too many arguments" lint failure with an #[allow()] annotation on the offending function.
  • Fix some new lifetime elision clippy lints introduced in rust 1.83.

@toolCHAINZ toolCHAINZ mentioned this pull request Dec 2, 2024
@toolCHAINZ toolCHAINZ changed the title Fix WASM build by pinning cc v1.1 Fix CI Dec 9, 2024
@@ -17,6 +17,7 @@ repository = "https://github.com/prove-rs/z3.rs.git"

[build-dependencies]
bindgen = { version = "0.70", default-features = false, features = ["runtime"] }
cc = "~1.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here about why this is pinned, so that we remember easier and can go back and fix it more correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note in 531708c

z3/src/ast.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@waywardmonkeys waywardmonkeys merged commit 4f9fcfe into prove-rs:master Dec 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants