Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] Fix v1 pagination #3181

Closed
wants to merge 3 commits into from
Closed

Conversation

Mgrdich
Copy link
Contributor

@Mgrdich Mgrdich commented Dec 30, 2022

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
modified the Filters code little bit to integrate the pagination

Is there anything you'd like reviewers to focus on?
checking the Filters.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Mgrdich Mgrdich requested a review from a team as a code owner December 30, 2022 12:41
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Dec 30, 2022
@Mgrdich Mgrdich linked an issue Dec 30, 2022 that may be closed by this pull request
@Mgrdich Mgrdich added the type/bug Something isn't working label Dec 30, 2022
@Mgrdich Mgrdich self-assigned this Dec 30, 2022
@Mgrdich Mgrdich force-pushed the issues/3129_Filters_v1_pagination branch 2 times, most recently from 78f89fb to 0128bfd Compare January 3, 2023 11:48
@Mgrdich Mgrdich force-pushed the issues/3129_Filters_v1_pagination branch from 0128bfd to 8662eb0 Compare January 10, 2023 08:34
@Haarolean Haarolean added status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. and removed status/triage Issues pending maintainers triage labels Jan 11, 2023
@Haarolean Haarolean assigned armenuikafka and unassigned Mgrdich Jan 11, 2023
@Haarolean Haarolean requested a review from a team January 11, 2023 02:33
@Haarolean Haarolean changed the title Issues/3129 filters v1 pagination [FE] Fix v1 pagination Jan 11, 2023
@Haarolean Haarolean added status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. and removed status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. labels Jan 11, 2023
@github-actions
Copy link

Custom deployment removed

@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

54.1% 54.1% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Custom deployment will be available at http://pr3181.internal.kafka-ui.provectus.io

1 similar comment
@github-actions
Copy link

Custom deployment will be available at http://pr3181.internal.kafka-ui.provectus.io

@armenuikafka
Copy link

@Haarolean http://pr3181.internal.kafka-ui.provectus.io/ is not available

Copy link

@armenuikafka armenuikafka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 100th message is displayed twice: on first page and also on second page

100th.message.mov

@armenuikafka armenuikafka removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Jan 19, 2023
@Haarolean Haarolean assigned Mgrdich and unassigned armenuikafka Jan 23, 2023
@Haarolean Haarolean closed this Mar 15, 2023
@Haarolean Haarolean deleted the issues/3129_Filters_v1_pagination branch June 20, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages pagination is broken
4 participants