Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics and Graphs #4051

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Metrics and Graphs #4051

wants to merge 42 commits into from

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Jul 20, 2023 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

iliax added 30 commits June 20, 2023 11:26
wip
38eb68d
wip
54a5398
test fix
daedc4d
wip
dbab4e3
wip
70b0849
wip
dc95269
wip
cb159e1
wip
5474a34
wip
98b1aa5
wip
8062492
Merge branch 'master' of github.com:provectus/kafka-ui into metrics
9f2bca1 
� Conflicts:
�	documentation/compose/jmx-exporter/kafka-broker.yml
�	documentation/compose/kafka-ui-arm64.yaml
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/BrokersController.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/integration/odd/TopicsExporter.java
checkstyle fixes
9d2ecf5
wip
3051078
wip
8e6b47a
wip
3facb82
tests
13a5582
prom unit parsing impl
7c3fb18
wip
12c6552
wip
0ec59e8
wip
3789693
wip
7e3831b
wip
a9a22b4
wip
35910fc
wip
e9793ec
wip
28c9871
wip
d6c16e2
wip
0661575
wip
3da32c9
wip
4bd70b7
wip
7eeb553
iliax added 4 commits July 21, 2023 20:21
wip
e5539f2
wip
725c823
wip
3a4233f
Merge branch 'master' of github.com:provectus/kafka-ui into metrics_ph2
79ba831 
� Conflicts:
�	kafka-ui-api/src/test/java/com/provectus/kafka/ui/AbstractIntegrationTest.java
@iliax iliax changed the title Metrics ph1,2 Metrics and Graphs Jul 24, 2023
@iliax iliax marked this pull request as ready for review July 24, 2023 10:38
@iliax iliax requested review from a team and Haarolean as code owners July 24, 2023 10:38
@iliax iliax requested a review from germanosin July 24, 2023 10:38
@sonarcloud
Copy link

sonarcloud bot commented Aug 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Awaiting requested review from Haarolean

@germanosin germanosin Awaiting requested review from germanosin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iliax