closes Format numbers with locale #4036 #4272
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed format of number of messages
What changes did you make? (Give an overview)
modified
return partitions.reduce((memo, { offsetMax, offsetMin }) => { return memo + (offsetMax - offsetMin); }, 0);
with
const totalMessages = partitions.reduce((memo, { offsetMax, offsetMin }) => { return memo + (offsetMax - offsetMin); }, 0); return totalMessages.toLocaleString(); // Format with comma separators },
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
i have applied this test as shown went successfully