Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closed/Issues/4377 #4380

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

BenedettoMarcoSerinelli
  • KAFKA_UI_PREFERENCES_REMOVEGITLINK: remove git link
  • KAFKA_UI_PREFERENCES_REMOVEDISCORDLINK: remove discord link
  • KAFKA_UI_PREFERENCES_APPNAME: change app name from Kafka UI to the desiderata
  • ** KAFKA_UI_PREFERENCES_FAVICON: change favicon to the desiderata ** (please add data:image/png;base64,)
  • **KAFKA_UI_PREFERENCES_LOGO: change favicon to the desiderata ** (please add data:image/png;base64,)
  • ** KAFKA_UI_PREFERENCES_VERSION: to remove version banner**

What changes did you make? (Give an overview)
I tried to implement a branded operation to custom the kafka-ui for other purposes. Kafka-ui can show brand logo, favicon app name, removing the links to git, discord and version.

Changing the src/main/resources/swagger/kafka-ui-api.yaml swagger, I created new FE and BE api endpoint, called Preferences

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
cat
My apologise for any errors (it is my first contribution!)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there BenedettoMarcoSerinelli! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant