Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add several new features from latest release #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mhernahapetyan
Copy link

@mhernahapetyan mhernahapetyan commented Jul 4, 2022

Added several new features for external-dns -- https://artifacthub.io/packages/helm/bitnami/external-dns
Checking readyness, liveness, also addes features to select log level and log format, desired cout of replicas of external-dns
also added dry run feature,when it is enabled the dns changes will not be performed

@wallhided
Copy link
Contributor

@mhernahapetyan
How you check your modules during development?
I tried to import your module from your branch with following configuration
module external_dns { source = "github.com/provectus/sak-external-dns?ref=add_several_features_from_latest_release" cluster_name = module.kubernetes.cluster_name argocd = module.argocd.state hostedzones = ["Z04283821FJSE3Y1JZN94"] }

And I received:
│ Error: Invalid function argument │ │ on .terraform/modules/external_dns/main.tf line 202, in locals: │ 202: "value" = tostring(value) │ │ Invalid value for "v" parameter: cannot convert list of string to string.

@wallhided
Copy link
Contributor

Please add description of PR (What you have done and etc)

@mhernahapetyan mhernahapetyan requested a review from wallhided July 7, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants