Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precommit hook #28

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Add precommit hook #28

merged 1 commit into from
Dec 18, 2024

Conversation

nateinaction
Copy link
Member

@nateinaction nateinaction commented Aug 3, 2024

Following @TheSilentDefender's suggestion, this PR implements a precommit hook which runs the previously implemented linter black as well as a few additional white space checks. All code changes are whitespace only and should not impact compilation or runtime behavior.

The manual file modifications in this PR are:

  • .pre-commit-config.yaml
  • README.md
  • requirements.txt

This is what is looks like when the precommit hook runs:

pre-commit run --all-files
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check Yaml...............................................................Passed
Check for added large files..............................................Passed
black....................................................................Passed

Copy link
Contributor

@blakejameson blakejameson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the code on my machine, and it worked. Great job Nate

@nateinaction nateinaction merged commit be164be into main Dec 18, 2024
1 check passed
@nateinaction nateinaction deleted the precommit-hook branch December 18, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants