Skip to content

Commit

Permalink
chore: correction
Browse files Browse the repository at this point in the history
  • Loading branch information
HugoPBrito committed Oct 15, 2024
1 parent 55bd76e commit 1547c22
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ def execute(self):

if report.status == "FAIL":
if rules_metrics_disabled and rule_groups_metrics_disabled:
report.status_extended = f"AWS WAFv2 Web ACL {web_acl.id} does not have CloudWatch Metrics enabled in all rule groups and rules. Non compliant resources are: Rules: {", ".join(rules_metrics_disabled)}. Rule Groups: {", ".join(rule_groups_metrics_disabled)}."
report.status_extended = f"AWS WAFv2 Web ACL {web_acl.id} does not have CloudWatch Metrics enabled in all rule groups and rules. Non compliant resources are: Rules: {', '.join(rules_metrics_disabled)}. Rule Groups: {', '.join(rule_groups_metrics_disabled)}."

Check warning on line 35 in prowler/providers/aws/services/wafv2/wafv2_cloudwatch_metrics_enabled/wafv2_cloudwatch_metrics_enabled.py

View check run for this annotation

Codecov / codecov/patch

prowler/providers/aws/services/wafv2/wafv2_cloudwatch_metrics_enabled/wafv2_cloudwatch_metrics_enabled.py#L35

Added line #L35 was not covered by tests
elif rules_metrics_disabled:
report.status_extended = f"AWS WAFv2 Web ACL {web_acl.id} does not have CloudWatch Metrics enabled in all rule groups and rules. Non compliant resources are: Rules: {", ".join(rules_metrics_disabled)}."
report.status_extended = f"AWS WAFv2 Web ACL {web_acl.id} does not have CloudWatch Metrics enabled in all rule groups and rules. Non compliant resources are: Rules: {', '.join(rules_metrics_disabled)}."
elif rule_groups_metrics_disabled:
report.status_extended = f"AWS WAFv2 Web ACL {web_acl.id} does not have CloudWatch Metrics enabled in all rule groups and rules. Non compliant resources are: Rule Groups: {", ".join(rule_groups_metrics_disabled)}."
report.status_extended = f"AWS WAFv2 Web ACL {web_acl.id} does not have CloudWatch Metrics enabled in all rule groups and rules. Non compliant resources are: Rule Groups: {', '.join(rule_groups_metrics_disabled)}."

findings.append(report)

Expand Down

0 comments on commit 1547c22

Please sign in to comment.