Skip to content

Commit

Permalink
chore: revision
Browse files Browse the repository at this point in the history
  • Loading branch information
sergargar committed Oct 16, 2024
1 parent 7fb6219 commit 51b3afa
Showing 1 changed file with 26 additions and 19 deletions.
45 changes: 26 additions & 19 deletions prowler/providers/aws/services/wafv2/wafv2_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,23 @@ def _list_web_acls_global(self):
logger.info("WAFv2 - Listing Global Web ACLs...")
if "us-east-1" in self.regional_clients:
try:
regional_client = self.regional_clients["us-east-1"]
for wafv2 in regional_client.list_web_acls(Scope="CLOUDFRONT")["WebACLs"]:
if not self.audit_resources or (
is_resource_filtered(wafv2["ARN"], self.audit_resources)
):
arn = wafv2["ARN"]
self.web_acls[arn] = WebAclv2(
arn=arn,
name=wafv2["Name"],
id=wafv2["Id"],
albs=[],
user_pools=[],
scope=Scope.CLOUDFRONT,
region="us-east-1",
)
regional_client = self.regional_clients["us-east-1"]
for wafv2 in regional_client.list_web_acls(Scope="CLOUDFRONT")[
"WebACLs"
]:
if not self.audit_resources or (
is_resource_filtered(wafv2["ARN"], self.audit_resources)
):
arn = wafv2["ARN"]
self.web_acls[arn] = WebAclv2(
arn=arn,
name=wafv2["Name"],
id=wafv2["Id"],
albs=[],
user_pools=[],
scope=Scope.CLOUDFRONT,
region="us-east-1",
)
except Exception as error:
logger.error(

Check warning on line 48 in prowler/providers/aws/services/wafv2/wafv2_service.py

View check run for this annotation

Codecov / codecov/patch

prowler/providers/aws/services/wafv2/wafv2_service.py#L47-L48

Added lines #L47 - L48 were not covered by tests
f"us-east-1 -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
Expand Down Expand Up @@ -132,11 +134,16 @@ def _get_web_acl(self, acl: str):
rules = get_web_acl.get("WebACL", {}).get("Rules", [])
for rule in rules:
new_rule = Rule(
name=rule.get("Name", ""), cloudwatch_metrics_enabled=rule.get("VisibilityConfig", {}).get(
"CloudWatchMetricsEnabled", False
)
name=rule.get("Name", ""),
cloudwatch_metrics_enabled=rule.get("VisibilityConfig", {}).get(
"CloudWatchMetricsEnabled", False
),
)
if rule.get("Statement",{}).get("RuleGroupReferenceStatement",{}).get("ARN"):
if (
rule.get("Statement", {})
.get("RuleGroupReferenceStatement", {})
.get("ARN")
):
acl.rule_groups.append(new_rule)
else:
acl.rules.append(new_rule)
Expand Down

0 comments on commit 51b3afa

Please sign in to comment.