feat: change id for name in status extended

prowler-cloud · Oct 16, 2024 · 9590d66 · 9590d66
1 parent 0268d77
commit 9590d66
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/...ervices/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades.py b/...ervices/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades.py
@@ -12,11 +12,11 @@ def execute(self):
             report.resource_arn = broker.arn
             report.resource_tags = broker.tags
             report.status = "PASS"
-            report.status_extended = f"MQ Broker {broker.id} does have automated minor version upgrades enabled."
+            report.status_extended = f"MQ Broker {broker.name} does have automated minor version upgrades enabled."
 
             if not broker.auto_minor_version_upgrade:
                 report.status = "FAIL"
-                report.status_extended = f"MQ Broker {broker.id} does not have automated minor version upgrades enabled."
+                report.status_extended = f"MQ Broker {broker.name} does not have automated minor version upgrades enabled."
 
             findings.append(report)
 

diff --git a/...es/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades_test.py b/...es/mq/mq_broker_auto_minor_version_upgrades/mq_broker_auto_minor_version_upgrades_test.py
@@ -38,8 +38,9 @@ def test_no_brokers(self):
     @mock_aws
     def test_broker_auto_minor_version_upgrades_enabled(self):
         mq_client = client("mq", region_name=AWS_REGION_US_EAST_1)
+        broker_name = "test-broker"
         broker_id = mq_client.create_broker(
-            BrokerName="test-broker",
+            BrokerName=broker_name,
             EngineType="ACTIVEMQ",
             EngineVersion="5.15.0",
             HostInstanceType="mq.t2.micro",
@@ -78,7 +79,7 @@ def test_broker_auto_minor_version_upgrades_enabled(self):
                 assert result[0].status == "PASS"
                 assert (
                     result[0].status_extended
-                    == f"MQ Broker {broker_id} does have automated minor version upgrades enabled."
+                    == f"MQ Broker {broker_name} does have automated minor version upgrades enabled."
                 )
                 assert result[0].resource_id == broker_id
                 assert (
@@ -90,8 +91,9 @@ def test_broker_auto_minor_version_upgrades_enabled(self):
     @mock_aws
     def test_broker_auto_minor_version_upgrades_disabled(self):
         mq_client = client("mq", region_name=AWS_REGION_US_EAST_1)
+        broker_name = "test-broker"
         broker_id = mq_client.create_broker(
-            BrokerName="test-broker",
+            BrokerName=broker_name,
             EngineType="ACTIVEMQ",
             EngineVersion="5.15.0",
             HostInstanceType="mq.t2.micro",
@@ -130,7 +132,7 @@ def test_broker_auto_minor_version_upgrades_disabled(self):
                 assert result[0].status == "FAIL"
                 assert (
                     result[0].status_extended
-                    == f"MQ Broker {broker_id} does not have automated minor version upgrades enabled."
+                    == f"MQ Broker {broker_name} does not have automated minor version upgrades enabled."
                 )
                 assert result[0].resource_id == broker_id
                 assert (